Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2215 Do not reuse WebsocketClientSpec.Builder between Requests #2216

Merged
merged 1 commit into from May 21, 2021
Merged

#2215 Do not reuse WebsocketClientSpec.Builder between Requests #2216

merged 1 commit into from May 21, 2021

Conversation

Johannes-Rost
Copy link
Contributor

A possible fix for #2215

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #2216 (d35bb64) into master (6466f73) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2216      +/-   ##
============================================
+ Coverage     78.16%   78.19%   +0.02%     
- Complexity     1301     1303       +2     
============================================
  Files           166      166              
  Lines          4983     4985       +2     
  Branches        426      426              
============================================
+ Hits           3895     3898       +3     
  Misses          873      873              
+ Partials        215      214       -1     
Impacted Files Coverage Δ Complexity Δ
...cloud/gateway/config/GatewayAutoConfiguration.java 88.88% <100.00%> (+0.13%) 70.00 <0.00> (ø)
...eway/filter/factory/RetryGatewayFilterFactory.java 78.94% <0.00%> (+0.58%) 40.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6466f73...d35bb64. Read the comment docs.

@Johannes-Rost
Copy link
Contributor Author

The fix from #2160 does not really work without this one. My test setup was incomplete: Although the websocket connection reaches the backend service, the handshake in the gateway cannot be completed, without this fix.

@Johannes-Rost
Copy link
Contributor Author

Could you tell me whether this fix will be included in 3.0.3?
For #2159 we switched back to Hoxton.SR10 and Spring Boot 2.3.9.RELEASE (That is why we did not notice that the fix was incomplete). Since we did not want to go back again, we are running this fix in production and it is working.
We would like to replace our patched version of 3.0.2 with an official release as soon as possible.

@spencergibb spencergibb added this to In progress in 2020.0.3 via automation Apr 27, 2021
@spencergibb spencergibb added this to the 3.0.3 milestone Apr 27, 2021
@spencergibb spencergibb merged commit e9bf4e5 into spring-cloud:main May 21, 2021
2020.0.3 automation moved this from In progress to Done May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
2020.0.3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants