Add failing test case for class generated by Groovy compiler #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies spotbugsTestCases/build.gradle to add Groovy support and cleans up / refactors the AbstractIntegrationTest to read .class files generated by the Groovy compiler. At the same time simplifies some logic and switches use of java.io.File over to the java.nio.file package instead.
ThrawnCA
previously approved these changes
Aug 22, 2022
Signed-off-by: Kengo TODA <skypencil@gmail.com>
…ss-test-case-error
Signed-off-by: Kengo TODA <skypencil@gmail.com>
Signed-off-by: Kengo TODA <skypencil@gmail.com>
KengoTODA
force-pushed
the
bug/2145-groovy-class-test-case-error
branch
from
de39725
to
d48728d
Compare
KengoTODA
previously approved these changes
Aug 28, 2022
There was a problem hiding this comment.
Thanks for your PR!
I confirmed that the bug comes from 771f26f which assumes the size of field is always 1. I will wait for review from other teammates to merge this fix and your test case. I had misunderstanding about the intention of existing code, I will reconsider my fix.
Signed-off-by: Kengo TODA <skypencil@gmail.com>
Signed-off-by: Kengo TODA <skypencil@gmail.com>
KengoTODA
approved these changes
Aug 28, 2022
ThrawnCA
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a failing test case for Groovy class that is causing Spotbugs to throw
edu.umd.cs.findbugs.ba.CFGBuilderException. It does not fix the issue. Refer to #2145spotbugsTestCases/build.gradleAbstractIntegrationTesthas been cleaned up / refactored to additionally search for.classfiles generated by the Groovy compiler. At the same time simplifies some fall-back search path logic (e.g. presumably left over code for nonexistentjava9/directory) and switches use ofjava.io.Fileover to thejava.nio.filepackage instead.Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs codeNOTE: No fix in this PR