CFGBuilderException when assigning double or long in groovy constructor #2145
Comments
|
Thanks for opening your first issue here! 😃 |
tmoschou
changed the title
tmoschou
added a commit
to tmoschou/spotbugs
that referenced
this issue
Aug 19, 2022
This modifies spotbugsTestCases/build.gradle to add Groovy support and cleans up / refactors the AbstractIntegrationTest to read .class files generated by the Groovy compiler. At the same time simplifies some logic and switches use of java.io.File over to the java.nio.file package instead.
tmoschou
added a commit
to tmoschou/spotbugs
that referenced
this issue
Aug 19, 2022
This modifies spotbugsTestCases/build.gradle to add Groovy support and cleans up / refactors the AbstractIntegrationTest to read .class files generated by the Groovy compiler. At the same time simplifies some logic and switches use of java.io.File over to the java.nio.file package instead.
1 task
bytecode of Class1public class Class1 implements groovy/lang/GroovyObject {
|
According to the Next, point is that operands after the How it changes operand stack depth? The answer is 2: Then |
|
according to the following debug log: diff --git a/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/BetterCFGBuilder2.java b/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/BetterCFGBuilder2.java
index 734d9eed6..347383e2b 100644
--- a/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/BetterCFGBuilder2.java
+++ b/spotbugs/src/main/java/edu/umd/cs/findbugs/ba/BetterCFGBuilder2.java
@@ -924,6 +924,19 @@ public class BetterCFGBuilder2 implements CFGBuilder, EdgeTypes, Debug {
}
}
+ private int countConsumedStack(Instruction inst) {
+ int consume = inst.consumeStack(cpg);
+ if (consume == Const.UNPREDICTABLE) {
+ throw new RuntimeException("unexpected consume for " + inst);
+ }
+ int produce = inst.produceStack(cpg);
+ if (produce == Const.UNPREDICTABLE) {
+ throw new RuntimeException("unexpected produce for " + inst);
+ }
+ System.err.printf("%s: stack size changed %d (produced %d, consumed %d)%n", inst, produce - consume, produce, consume);
+ return consume - produce;
+ }
+
/**
* Add exception edges for given instruction.
*
@@ -1010,6 +1023,7 @@ public class BetterCFGBuilder2 implements CFGBuilder, EdgeTypes, Debug {
if (ins instanceof PUTFIELD && !methodGen.isStatic()) {
// Assume that PUTFIELD on this object is not PEI
int depth = ins.consumeStack(cpg);
+ StringBuilder sb = new StringBuilder().append('\n').append(handle).append(" (depth:").append(depth).append(')');
for (InstructionHandle prev = handle.getPrev(); prev != null; prev = prev.getPrev()) {
Instruction prevInst = prev.getInstruction();
if (prevInst instanceof BranchInstruction) {
@@ -1027,9 +1041,10 @@ public class BetterCFGBuilder2 implements CFGBuilder, EdgeTypes, Debug {
return true;
}
}
- depth = depth - prevInst.produceStack(cpg) + prevInst.consumeStack(cpg);
+ depth = depth + countConsumedStack(prevInst);
+ sb.append('\n').append(prev).append(" (depth:").append(depth).append(')');
if (depth < 1) {
- throw new CFGBuilderException("Invalid stack at " + prev + " when checking " + handle);
+ throw new CFGBuilderException("Invalid stack at " + prev + " when checking " + handle + sb);
}
if (depth == 1) {
InstructionHandle prevPrev = prev.getPrev(); |
KengoTODA
pushed a commit
that referenced
this issue
Aug 28, 2022
This modifies spotbugsTestCases/build.gradle to add Groovy support and cleans up / refactors the AbstractIntegrationTest to read .class files generated by the Groovy compiler. At the same time simplifies some logic and switches use of java.io.File over to the java.nio.file package instead.
|
The point is that the current code does not consider Not sure why Groovy prefers |
1 task
KengoTODA
pushed a commit
that referenced
this issue
Sep 1, 2022
This modifies spotbugsTestCases/build.gradle to add Groovy support and cleans up / refactors the AbstractIntegrationTest to read .class files generated by the Groovy compiler. At the same time simplifies some logic and switches use of java.io.File over to the java.nio.file package instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This minimal Groovy class
src/main/groovy/Class1.groovywith Java class main method entry point and maven
pom.xmlsrc/main/java/Main.javapom.xmlcauses Spotbugs to crash with
I have created a minimal maven reproducible example of the above here https://github.com/tmoschou/bug-repro-spotbugs using the
spotbugs-maven-pluginandgmavenplus-pluginto build the mix Groovy/Java projectVersions
I am using the latest versions at the time of writing for every dependency and plugin
com.github.spotbugs:spotbugs:4.7.1com.github.spotbugs:spotbugs-maven-plugin:4.7.1.1org.apache.groovy:groovy-all:4.0.4org.codehaus.gmavenplus:gmavenplus-plugin:1.13.1Steps to reproduce.
mvn clean verifyOther notes
This seems to be an issue using
doubleorlongspecifically.floatandintare fine.I have set
maxRankto1.Seems related to #1386 opened two years ago (against Groovy 2) - but there has not been any activity.
Disassembled
Class1.classusingjavap -p -l -v -c Class1Click to expand
Decompiled
Class1.classusing IntelliJ IDEA and FernFlowerClick to expand
The text was updated successfully, but these errors were encountered: