Enhancement for issue #2061. #2069
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotbugs/src/main/java/edu/umd/cs/findbugs/ba/ResourceValueFrame.java
Outdated
Show resolved
Hide resolved
ThrawnCA
previously approved these changes
May 31, 2022
|
There was an unnecessary line break ( |
ThrawnCA
approved these changes
Jun 2, 2022
JuditKnoll
reviewed
Aug 1, 2023
| @@ -5,6 +5,9 @@ This is the changelog for SpotBugs. This follows [Keep a Changelog v1.0.0](http: | |||
| Currently the versioning policy of this project follows [Semantic Versioning v2.0.0](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## Unreleased - 2022-??-?? | |||
| ### Changed | |||
| - Rewrite some member in `ResourceValueFrame.java` to Enum([#2061](https://github.com/spotbugs/spotbugs/issues/2061)) | |||
There was a problem hiding this comment.
This is a major, breaking change, IMO it would be better, if the changelog contained that it's a breaking change.
There was a problem hiding this comment.
Is it though? Is there external usage of this? I don't see it in the gradle or maven plugins, maybe something else is using it. Can call it breaking I guess given its public got thinking its ok.
ThrawnCA
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement for issue #2061, reimplement
ResourceValueFrame.java.Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code