Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected class name validation to no longer fail for Kotlin classes on class path containing special characters #1884

Merged
merged 5 commits into from
Dec 22, 2021
Merged

Corrected class name validation to no longer fail for Kotlin classes on class path containing special characters #1884

merged 5 commits into from
Dec 22, 2021

Commits on Dec 21, 2021

  1. Added test cases to demonstrate incorrect name validation.

    @studro
    studro committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    d93c5f7 View commit details
    Browse the repository at this point in the history

  2. Improved class name verification to match JVM specification. 

    Also added logic to allow existing cases where a field descriptor
or dotted class name is provided instead of a slashed (binary)
class name.
    @studro
    studro committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    8f8ea18 View commit details
    Browse the repository at this point in the history

  3. Updated CHANGELOG.md.

    @studro
    studro committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    4e26eb1 View commit details
    Browse the repository at this point in the history

  4. Implemented code review feedback. 

    * Documented private methods in class name validity checker with links to JVM spec.
* Cleaned up array type checking code.
* Added test to ensure that empty class names are rejected.
    @studro
    studro committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    6b1523b View commit details
    Browse the repository at this point in the history

  5. Fixing incorrect exception documentation in ClassName#isValidArrayFie… 

    …ldDescriptor.
    @studro
    studro committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0cfd02c View commit details
    Browse the repository at this point in the history