Corrected class name validation to no longer fail for Kotlin classes on class path containing special characters

[studro]

Closes #1883.

---

Make sure these boxes are checked before submitting your PR -- thank you!

• Added an entry into CHANGELOG.md if you have changed SpotBugs code

[KengoTODA]

Just one mandatory request exists in isValidBinaryClassName() methods, to follow the definition in the JVMS.
Other feedback are just my 2 cents. Thanks for your PR!

[KengoTODA]

It's just my personal and unreasonable motivation. JIT could be enough.

Suggested change

	return className.startsWith("[") &&
	(isValidArrayFieldDescriptor(className.substring(1))) ||
	isValidClassFieldDescriptor(className.substring(1)) ||
	isValidBaseTypeFieldDescriptor(className.substring(1));
	String tail = className.substring(1);
	return className.startsWith("[") &&
	(isValidArrayFieldDescriptor(tail)) ||
	isValidClassFieldDescriptor(tail) ||
	isValidBaseTypeFieldDescriptor(tail);

[studro]

I actually thinks this improves readability too, so this might be a good change. 👍

However, I am concerned about the possibility of throwing an IndexOutOfBoundsException if this is called with an empty string (instead of returning false). I have added an isEmpty() check in the caller and documentation to mitigate this concern.

[KengoTODA]

👍 Confirmed that all descriptions listed in the JVMS are covered.

[studro]

Just one mandatory request exists in isValidBinaryClassName() methods, to follow the definition in the JVMS. Other feedback are just my 2 cents. Thanks for your PR!

Thanks for your quick and thorough review. I've attempted to address the comments you've raised and will be happy to make any further changes as necessary. 😄

[studro]

I am very sorry to be difficult, but one final review is required, if possible.
I've updated the exception documentation as I noted in #1884 (comment). While this was only a minor issue, what I had written was completely wrong.
I also noticed that I had the incorrect commit author email set for this project (my personal instead of no-reply github email), so I've updated history with a force push to correct that.
Thanks for your patience and hopefully this is now the end of this issue! 😊