Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop jQuery and UnderscoreJS #9874

Closed
wants to merge 2 commits into from
Closed

Drop jQuery and UnderscoreJS #9874

wants to merge 2 commits into from

Conversation

pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Nov 20, 2021 •
edited

Toward #7405

  • Port doctools.js
    • (missing piece right now is make the search highlighting work)
    • Update tests
  • Port searchtools.js
    • Update tests
  • Documentation callouts
  • Changelog entry

Live-ish list of changes:

  • Make all JS function utilities "private", by prefixing an underscore.
  • When highlighting content, only highlight content within [role="main"],
    since that is where the search is done.
  • Only handle toggle buttons for domainindex.js, in [role="main"].
  • Drop unused JS functions: addContextElements, getCurrentURL, makeURL.

@pradyunsg pradyunsg mentioned this pull request Nov 20, 2021
Closed
@astrojuanlu astrojuanlu mentioned this pull request Dec 15, 2021
Closed
@AA-Turner AA-Turner mentioned this pull request Dec 29, 2021
Merged
@AA-Turner
Copy link
Member

@pradyunsg can this be closed since #10028 was merged?

A

@pradyunsg
Copy link
Contributor Author

Yes!

@pradyunsg pradyunsg closed this Feb 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pradyunsg @AA-Turner