- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Closed
Labels
help wantedhtml searchhtml themetype:enhancementenhance or introduce a new featureenhance or introduce a new feature
Milestone
Description
Most things we use jQuery for can now easily be done using vanilla JS even in IE11.
Removing jQuery therefore does not impact browser coverage significantly and instead leads to a smaller website to serve. As this is be a breaking change I would propose to discuss about implementing this for the 4.x release next year.
If the consensus is to go ahead with removing jQuery I would volunteer for this.
randombit, ZibingZhang, sezgi, astrojuanlu, drj11 and 1 morepradyunsg, Domest0s and tkoyama010
Metadata
Metadata
Assignees
Labels
help wantedhtml searchhtml themetype:enhancementenhance or introduce a new featureenhance or introduce a new feature
Projects
Relationships
Development
Select code repository
Activity
tk0miya commentedon Apr 3, 2020
+0: I don't have a strong opinion for your proposal.
@TimKam Any comments?
TimKam commentedon Apr 3, 2020
I like the idea and was actually contemplating it, but we need to make sure we don't introduce bugs on the way, so it will require some effort. Happy to get some help.
mgeier commentedon Mar 6, 2021
What about a configuration setting that allows to select whether jQuery should be loaded or not?
If the default value is to use jQuery, this wouldn't be a breaking change, but if people want a smaller website, they could opt out.
tk0miya commentedon Mar 6, 2021
Not to load jQuery simply causes errors in our JS. It seems the full-text search becomes not working. I think it's broken switch. So we need to refactor our JS before adding such a configuration.
TimKam commentedon Mar 6, 2021
Still, it could be a starting point to first use a flag, if we are concerned that there could be issues with legacy browsers (most likely, there will be issues with very old browsers, the only question is whether these browsers are relevant at all).
tk0miya commentedon Mar 6, 2021
I got the following errors if I removed the jQuery loading tag. And search form vanished. Is this really a good starting point?
TimKam commentedon Mar 6, 2021
Sorry, I meant: after an initial refactoring, it could be a good starting point to have flag for a while, so that people can switch back easily. But even there, I am not sure. Looking at the basic template, there are not too many occurrences.
25 remaining items