Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #7784: i18n: The alt text for image is translated by default #7979

Merged
merged 1 commit into from Jul 19, 2020
Merged

Close #7784: i18n: The alt text for image is translated by default #7979

merged 1 commit into from Jul 19, 2020

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jul 18, 2020

Feature or Bugfix

  • Feature

Purpose

@tk0miya tk0miya added type:enhancement enhance or introduce a new feature internals:internationalisation labels Jul 18, 2020
@tk0miya tk0miya added this to the 3.2.0 milestone Jul 18, 2020
@tk0miya tk0miya mentioned this pull request Jul 18, 2020
Closed
tk0miya
tk0miya commented Jul 18, 2020
View reviewed changes
CHANGES Show resolved Hide resolved
@tk0miya tk0miya requested a review from shimizukawa July 18, 2020 17:33
shimizukawa
shimizukawa approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tk0miya
Close sphinx-doc#7784: i18n: The alt text for image is translated by …
897be0e 
…default

Make alt text for image translatable by default without settings of
gettext_additional_targets.
@tk0miya tk0miya changed the base branch from 3.x to master July 19, 2020 03:58
@tk0miya tk0miya force-pushed the 7784_translate_image_alt_text_by_default branch from fadba2d to 897be0e Compare July 19, 2020 03:58
@tk0miya tk0miya merged commit dc63eaf into sphinx-doc:master Jul 19, 2020
@tk0miya tk0miya deleted the 7784_translate_image_alt_text_by_default branch July 19, 2020 04:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shimizukawa shimizukawa shimizukawa approved these changes

Assignees
No one assigned
Labels
internals:internationalisation type:enhancement enhance or introduce a new feature
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tk0miya @shimizukawa