Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No translation for :alt: of images #7784

Closed
kujiu opened this issue Jun 4, 2020 · 3 comments
Closed

No translation for :alt: of images #7784

kujiu opened this issue Jun 4, 2020 · 3 comments
Labels
internals:internationalisation type:proposal a feature suggestion
Milestone
3.2.0

Comments

@kujiu
Copy link

kujiu commented Jun 4, 2020

Describe the bug
Text of :alt: parameter of an image is not considered.

To Reproduce

Create a project, add an image directive with :alt: text and do make gettext.

Expected behavior

The text of :alt: property will be in the .pot file.

Environment info

  • OS: Linux OpenSuSE 15.2
  • Python version: 3.6
  • Sphinx version: 3.x and master branches
  • Sphinx extensions: No extension
  • Extra tools: None
@kujiu kujiu added the type:bug label Jun 4, 2020
@tk0miya tk0miya added this to the 3.1.0 milestone Jun 4, 2020
@tk0miya
Copy link
Member

tk0miya commented Jun 4, 2020

Absolutely. +1!

@tk0miya tk0miya modified the milestones: 3.1.0, 3.2.0 Jun 4, 2020
@kujiu kujiu mentioned this issue Jun 8, 2020
Closed
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jul 18, 2020
@tk0miya
Close sphinx-doc#7784: i18n: The alt text for image is translated by …
abfc6ea 
…default
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jul 18, 2020
@tk0miya
Close sphinx-doc#7784: i18n: The alt text for image is translated by …
fadba2d 
…default

Make alt text for image translatable by default without settings of
gettext_additional_targets.
@tk0miya tk0miya mentioned this issue Jul 18, 2020
Merged
@tk0miya
Copy link
Member

tk0miya commented Jul 18, 2020

At present, gettext_additional_targets is used to translate alt texts:
https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-gettext_additional_targets

But I just thought alt text should be translatable by default. So I post #7979.

@tk0miya tk0miya added type:proposal a feature suggestion and removed type:bug labels Jul 18, 2020
@shimizukawa
Copy link
Member

+1

tk0miya added a commit to tk0miya/sphinx that referenced this issue Jul 19, 2020
@tk0miya
Close sphinx-doc#7784: i18n: The alt text for image is translated by …
897be0e 
…default

Make alt text for image translatable by default without settings of
gettext_additional_targets.
tk0miya added a commit that referenced this issue Jul 19, 2020
@tk0miya
Merge pull request #7979 from tk0miya/7784_translate_image_alt_text_b…
dc63eaf 
…y_default

Close #7784: i18n: The alt text for image is translated by default
@tk0miya tk0miya closed this as completed Jul 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
internals:internationalisation type:proposal a feature suggestion
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
3 participants
@shimizukawa @tk0miya @kujiu