-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #6239: latex: Support to build Chinese documents #6398
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.0 #6398 +/- ##
==========================================
+ Coverage 83.59% 83.64% +0.05%
==========================================
Files 282 280 -2
Lines 40429 40404 -25
Branches 5956 5953 -3
==========================================
+ Hits 33796 33797 +1
+ Misses 5301 5281 -20
+ Partials 1332 1326 -6
Continue to review full report at Codecov.
|
7aab14a
to
4ded940
Compare
Should this be applied also for Korean language? |
@tk0miya I wonder if the |
Unfortunately, I don't know about both Chinese and Korean languages. So there are nothing to do to me for each language. Indeed, setting some |
from the xeCJK doc, it says its functions are:
|
xeCJK cares Korean too, but I think the default Korean font should be set manually.(For Chinese, if you don't set default Chinese font, it will fallback to fandol font.) From https://www.overleaf.com/learn/latex/Korean, it should be
|
@zhsj Are you saying xeCJK and XeLaTeX are also good for default settings for Korean? In addition, have you check the font setting is working fine with Sphinx? If so, I'll add them to next release. |
Nor can I speak/read Korean. So I'm not sure what is better to build PDF in Korean. I tried to build in a docker container with xeCJK for Korean doc.
Another way, which is used for https://docs.python.org/ko/3/download.html, the PDF is built with https://github.com/python/docsbuild-scripts/blob/c006512/build_docs.py#L74
Maybe @JulienPalard and @flowdas can have some comments too. kotex(left) and xeCJK(right) both work fine. But I have no idea which fonts are preferred in PDF. I find there are many fonts in texlive-lang-korean
|
I think helps from some Korean LaTeX users are needed to support Korean. Because it is hard to decide what is good default settings for them to me. How about asking this to users group? |
Feature or Bugfix
Purpose
So far, Sphinx can't build Chinese document correctly by default settings. So Chinese users would customize their settings to build PDF correctly. I'm afraid this breaks their project. But this surely improves Sphinx. So it would be better to add this into next minor release.