Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display 'replaceable hardcoded link' when link has a slash #10137

Merged
merged 2 commits into from Oct 5, 2022
Merged

Don't display 'replaceable hardcoded link' when link has a slash #10137

merged 2 commits into from Oct 5, 2022

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jan 26, 2022

Subject: don't display a 'replaceable hardcoded link' when it contains a slash

Feature or Bugfix

  • Bugfix

Purpose

  • this eliminates false positives in the hardcoded link warning

Relates

@tk0miya tk0miya changed the base branch from 4.x to 5.x May 22, 2022 12:54
@AA-Turner AA-Turner added the type:enhancement enhance or introduce a new feature label May 23, 2022
@AA-Turner AA-Turner added this to the 5.x milestone May 23, 2022
@AA-Turner AA-Turner modified the milestones: 5.x, 6.x Oct 4, 2022
@AA-Turner AA-Turner modified the milestones: 6.x, 5.3.0 Oct 5, 2022
@AA-Turner AA-Turner changed the title don't display a 'replaceable hardcoded link' when it contains a slash Don't display 'replaceable hardcoded link' when link has a slash Oct 5, 2022
@AA-Turner AA-Turner merged commit 6ed4bbb into sphinx-doc:5.x Oct 5, 2022
@asottile asottile deleted the no-warning-with-slash branch October 5, 2022 13:47
@AA-Turner
Copy link
Member

Thanks @asottile!

A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions type:enhancement enhance or introduce a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to bail out extlink replacement suggestion
2 participants