New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update conda lock + fix extlinks warnings #4543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably should have said that I'd had a stab at this myself, so we have duplicated some effort 😢
@@ -990,7 +990,7 @@ values. All other metadata members will be left unaltered. | |||
.. _CF Conventions: https://cfconventions.org/ | |||
.. _Cell Measures: https://cfconventions.org/Data/cf-conventions/cf-conventions-1.8/cf-conventions.html#cell-measures | |||
.. _Flags: https://cfconventions.org/Data/cf-conventions/cf-conventions-1.8/cf-conventions.html#flags | |||
.. _GitHub Issue: https://github.com/SciTools/iris/issues/new/choose | |||
.. _GitHub Discussion: https://github.com/SciTools/iris/discussions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why it's happy with the discussions but not the issues 🤷♀️
.. _readthedocs: https://readthedocs.org/ | ||
.. _GitHub: https://github.com/SciTools/iris/discussions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence that references this link is specifically about bug reports and feature requests. Not sure it makes sense to go via discussions???
For these ones, this pattern does work:
_GitHub: :issue:`new/choose`
It seems to go wrong where there is more than one word in the "handle" though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this pattern does work
Huh, maybe it doesn't: the build seems to work but produces a broken link, at least locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works 🎉
And finally, get in touch with us on :issue:`GitHub<new/choose>` if you have any issues or feature requests for improving Iris. Enjoy!
Note there is also a Sphinx PR that would make these warnings skip URLs with slashes, which is nearly all of ours sphinx-doc/sphinx#10137 |
🚀 Pull Request
Description
This PR replaces #4521.
Includes some tiptoe avoidance of
sphinx
extlinks
warnings whilst adopting the latestconda
lock file from #4521.This all seems to unblock adoption of
sphinx
4.4.0 without pinning.Consult Iris pull request check list