Skip to content

some domain directives generate wrong target ID #6903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tk0miya opened this issue Dec 8, 2019 · 0 comments
Closed

some domain directives generate wrong target ID #6903

tk0miya opened this issue Dec 8, 2019 · 0 comments

Comments

@tk0miya
Copy link
Member

tk0miya commented Dec 8, 2019

Describe the bug
Some domain directives generate wrong target ID. For example, both py:module and js:module generate target IDs with wrong operation. So they might be conflicted.

To Reproduce

This input are converted to following:

blah blah blah

.. js:module:: foo

blah blah blah

.. py:module:: foo

blah blah blah
<p>blah blah blah</p>
<span class="target" id="module-foo"></span><p>blah blah blah</p>
<span class="target" id="module-foo"></span><p>blah blah blah</p>

Expected behavior
All domain directives generate valid target IDs and they are not conflicted.

Your project
N/A

Screenshots
N/A

Environment info

  • OS: Mac
  • Python version: 3.8.0
  • Sphinx version: 2.2.2
  • Sphinx extensions: N/A
@tk0miya tk0miya added this to the 2.4.0 milestone Dec 8, 2019
@tk0miya tk0miya modified the milestones: 2.4.0, 3.0.0 Feb 4, 2020
tk0miya added a commit to tk0miya/sphinx that referenced this issue Mar 7, 2020
tk0miya added a commit that referenced this issue Mar 7, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Update CHANGES for #6903
@tk0miya tk0miya closed this as completed Mar 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant