Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std domain: Generate node_id for objects in the right way #7230

Merged
merged 2 commits into from Mar 6, 2020

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Feb 29, 2020

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #7230 into 3.x will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.x    #7230      +/-   ##
==========================================
+ Coverage   83.95%   83.96%   +0.01%     
==========================================
  Files         280      279       -1     
  Lines       43128    43110      -18     
  Branches     6299     6296       -3     
==========================================
- Hits        36207    36197      -10     
+ Misses       5543     5540       -3     
+ Partials     1378     1373       -5
Impacted Files Coverage Δ
tests/test_build_html.py 97.91% <ø> (ø) ⬆️
tests/test_domain_std.py 97.38% <ø> (ø) ⬆️
sphinx/domains/std.py 85.35% <100%> (+0.38%) ⬆️
tests/test_markup.py 98.29% <0%> (ø) ⬆️
sphinx/__init__.py
sphinx/writers/latex.py 83.98% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09623a9...c0535d7. Read the comment docs.

sphinx/domains/std.py Outdated Show resolved Hide resolved
@tk0miya tk0miya merged commit 5a848e3 into sphinx-doc:3.x Mar 6, 2020
@tk0miya tk0miya deleted the refactor_std_domain branch March 6, 2020 15:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant