py domain: Generate node_id for objects and modules in the right way #7236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
refactor_py_domain2
branch
2 times, most recently
from
b9a2546
to
edf2238
Compare
tk0miya
commented
Mar 1, 2020
| @@ -273,6 +273,7 @@ Additionally, the following filters are available | |||
| replaces the builtin Jinja `escape filter`_ that does html-escaping. | |||
|
|
|||
| .. function:: underline(s, line='=') | |||
| :noindex: | |||
There was a problem hiding this comment.
I think this would be an another bug. I'll take a look carefully tomorrow.
tk0miya
force-pushed
the
refactor_py_domain2
branch
from
edf2238
to
a1f835b
Compare
tk0miya
force-pushed
the
refactor_py_domain2
branch
from
a1f835b
to
f13c546
Compare
Codecov Report
@@ Coverage Diff @@
## 3.x #7236 +/- ##
==========================================
+ Coverage 84.01% 84.01% +<.01%
==========================================
Files 279 279
Lines 43087 43097 +10
Branches 6281 6282 +1
==========================================
+ Hits 36198 36208 +10
Misses 5517 5517
Partials 1372 1372
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose