Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds check-latest for setup-go action v3 #1729

Closed
wants to merge 1 commit into from
Closed

Adds check-latest for setup-go action v3 #1729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ jobs:
- uses: actions/setup-go@v3
with:
go-version: '1.17'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is go-version required if we use check-latest?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; it is "checking for the latest" on Go 1.17. So, in order to find the latest patch version, we need that option. We shouldn't be consuming base Go 1.17

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess my question is why do we want to use "the latest on Go 1.17", instead of "the latest Go", which is 1.18 ATM.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair - I'm up for that. Let me look into it quick!

check-latest: true

- uses: actions/checkout@v3

Expand Down