Adds check-latest for setup-go action v3
#1729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John McBride <jpmmcbride@gmail.com>
github-actions
bot
added
area/github
umarcor
reviewed
Jun 16, 2022
| @@ -16,6 +16,7 @@ jobs: | |||
| - uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: '1.17' | |||
There was a problem hiding this comment.
Is go-version required if we use check-latest?
There was a problem hiding this comment.
Yes; it is "checking for the latest" on Go 1.17. So, in order to find the latest patch version, we need that option. We shouldn't be consuming base Go 1.17
There was a problem hiding this comment.
I guess my question is why do we want to use "the latest on Go 1.17", instead of "the latest Go", which is 1.18 ATM.
There was a problem hiding this comment.
That's fair - I'm up for that. Let me look into it quick!
Closed
|
I just merged #1782 which I realize includes this PR 🤷♂️, so I'm going to close this as done. |
|
No worries! Thanks Marc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for v3 of
setup-goto check the latest patch version of Go.Related to #1660