Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win build: bump python, wine, pyinstaller #7721

Merged
merged 3 commits into from Mar 20, 2022

Commits on Mar 20, 2022

  1. Configuration menu
    Copy the full SHA
    185d54d View commit details
    Browse the repository at this point in the history
  2. win build: bump wine 6.0.2->7.0.0.0 to fix installing python

    with wine 6.0.2 and 6.0.3, cpython 3.9.11 fails to install (but cpython 3.9.10 worked)
    ```
    010c:err:virtual:virtual_setup_exception stack overflow 1220 bytes in thread 010c addr 0x7bc6713d stack 0x440b3c (0x440000-0x441000-0x640000)
    🗯 ERROR: wine msiexec failed for dev.msi
    🗯 ERROR: prepare-wine failed
    ```
    
    -----
    
    btw, related note:
    After changing the Dockerfile, building the docker image from cache failed. Setting ELECBUILD_NOCACHE=1 fixed it:
    ```
    E: Could not configure 'libc6:i386'.
    E: Could not perform immediate configuration on 'libgcc-s1:i386'. Please see man 5 apt.conf under APT::Immediate-Configure for details. (2)
    
    $ ELECBUILD_NOCACHE=1 ./contrib/build-wine/build.sh
    ```
    SomberNight committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    0e7b762 View commit details
    Browse the repository at this point in the history
  3. win build: update pyinstaller (from around 4.2 to around 4.10)

    see spesmilo#7721 (comment)
    
    -----
    
    pyinstaller 4.2 failed (during its runtime) to create exes (worked with cpython 3.9.10, but not with cpython 3.9.11):
    ```
    80572 INFO: Processing module hooks...
    80573 INFO: Loading module hook 'hook-certifi.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'...
    80618 INFO: Loading module hook 'hook-cryptography.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'...
    82879 INFO: Loading module hook 'hook-dns.rdata.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'...
    84147 INFO: Loading module hook 'hook-mnemonic.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'...
    84207 INFO: Loading module hook 'hook-pycparser.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'...
    84212 INFO: Loading module hook 'hook-usb1.py' from 'C:\\python3\\lib\\site-packages\\usb1\\__pyinstaller'...
    84215 INFO: --- libusb1 pyinstaller hook ---
    84226 INFO: Added libusb binaries: [('C:\\python3\\lib\\site-packages\\usb1\\libusb-1.0.dll', 'usb1')]
    84228 INFO: Loading module hook 'hook-difflib.py' from 'C:\\python3\\lib\\site-packages\\PyInstaller\\hooks'...
    84237 INFO: Excluding import of doctest from module difflib
    84237 INFO: Loading module hook 'hook-distutils.py' from 'C:\\python3\\lib\\site-packages\\PyInstaller\\hooks'...
    Unable to find "C:\python3\Include\pyconfig.h" when adding binary and data files.This would mean your Python installation doesn't
    come with proper library files. This usually happens by missing development
    package, or unsuitable build parameters of Python installation.
    * On Debian/Ubuntu, you would need to install Python development packages
      * apt-get install python3-dev
      * apt-get install python-dev
    * If you're building Python by yourself, please rebuild your Python with
    `--enable-shared` (or, `--enable-framework` on Darwin)
    
    🗯 ERROR: build-electrum-git failed
    ```
    
    Looks like this might be fixed in pyinstaller 4.3 (we are using 4.2):
    pyinstaller/pyinstaller#5218
    
    -----
    
    While trying to update pyinstaller to have that fix, several issues found with versions 4.3-4.10,
    now reported upstream and already fixed:
    pyinstaller/pyinstaller#6338
    pyinstaller/pyinstaller#6339
    pyinstaller/pyinstaller#6686
    
    So the pyinstaller commit pinned here is from the stable "v4" branch, some commits after the 4.10 tag,
    which has fixes for the above issues.
    SomberNight committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    b5951ad View commit details
    Browse the repository at this point in the history