win build: bump python, wine, pyinstaller #7721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the wine build of the Windows binaries is failing. The error is when trying to install python inside wine. With wine 7.0.0.0 (latest stable atm), the error goes away. (as in second commit) |
|
Re the Windows build, with wine 7.0.0.0, it is still failing but now much later with a new error. Looks like this might be fixed in pyinstaller 4.3 (we are using 4.2): |
SomberNight
added a commit
that referenced
this pull request
Mar 18, 2022
This is bumping the python versions bundled inside our binaries. For macOS and AppImage, from 3.9.10 to 3.9.11. For Android, from 3.8.12 to 3.8.13. Windows is left untouched as I am having issues with the wine build when using 3.9.11. (see #7721 (comment) )
SomberNight
force-pushed
the
202203_build_bump_python
branch
from
cf301f8
to
1e8d887
Compare
|
As I am having non-trivial issues with the Windows build, but the rest of the builds look fine, |
SomberNight
changed the title
|
On pyinstaller 4.3-4.6, the bootloader fails to build (i.e. we cannot cross-compile from linux). This error (pyinstaller/pyinstaller#6339), and another (pyinstaller/pyinstaller#6338) are fixed in pyinstaller 4.7. Using pyinstaller 4.7 (or 4.8 or 4.10), the whole build succeeds, however there is an issue at runtime. edit: opened pyinstaller/pyinstaller#6686 - see details there |
with wine 6.0.2 and 6.0.3, cpython 3.9.11 fails to install (but cpython 3.9.10 worked) ``` 010c:err:virtual:virtual_setup_exception stack overflow 1220 bytes in thread 010c addr 0x7bc6713d stack 0x440b3c (0x440000-0x441000-0x640000) 🗯 ERROR: wine msiexec failed for dev.msi 🗯 ERROR: prepare-wine failed ``` ----- btw, related note: After changing the Dockerfile, building the docker image from cache failed. Setting ELECBUILD_NOCACHE=1 fixed it: ``` E: Could not configure 'libc6:i386'. E: Could not perform immediate configuration on 'libgcc-s1:i386'. Please see man 5 apt.conf under APT::Immediate-Configure for details. (2) $ ELECBUILD_NOCACHE=1 ./contrib/build-wine/build.sh ```
see spesmilo#7721 (comment) ----- pyinstaller 4.2 failed (during its runtime) to create exes (worked with cpython 3.9.10, but not with cpython 3.9.11): ``` 80572 INFO: Processing module hooks... 80573 INFO: Loading module hook 'hook-certifi.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'... 80618 INFO: Loading module hook 'hook-cryptography.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'... 82879 INFO: Loading module hook 'hook-dns.rdata.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'... 84147 INFO: Loading module hook 'hook-mnemonic.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'... 84207 INFO: Loading module hook 'hook-pycparser.py' from 'C:\\python3\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'... 84212 INFO: Loading module hook 'hook-usb1.py' from 'C:\\python3\\lib\\site-packages\\usb1\\__pyinstaller'... 84215 INFO: --- libusb1 pyinstaller hook --- 84226 INFO: Added libusb binaries: [('C:\\python3\\lib\\site-packages\\usb1\\libusb-1.0.dll', 'usb1')] 84228 INFO: Loading module hook 'hook-difflib.py' from 'C:\\python3\\lib\\site-packages\\PyInstaller\\hooks'... 84237 INFO: Excluding import of doctest from module difflib 84237 INFO: Loading module hook 'hook-distutils.py' from 'C:\\python3\\lib\\site-packages\\PyInstaller\\hooks'... Unable to find "C:\python3\Include\pyconfig.h" when adding binary and data files.This would mean your Python installation doesn't come with proper library files. This usually happens by missing development package, or unsuitable build parameters of Python installation. * On Debian/Ubuntu, you would need to install Python development packages * apt-get install python3-dev * apt-get install python-dev * If you're building Python by yourself, please rebuild your Python with `--enable-shared` (or, `--enable-framework` on Darwin) 🗯 ERROR: build-electrum-git failed ``` Looks like this might be fixed in pyinstaller 4.3 (we are using 4.2): pyinstaller/pyinstaller#5218 ----- While trying to update pyinstaller to have that fix, several issues found with versions 4.3-4.10, now reported upstream and already fixed: pyinstaller/pyinstaller#6338 pyinstaller/pyinstaller#6339 pyinstaller/pyinstaller#6686 So the pyinstaller commit pinned here is from the stable "v4" branch, some commits after the 4.10 tag, which has fixes for the above issues.
SomberNight
force-pushed
the
202203_build_bump_python
branch
from
1e8d887
to
b5951ad
Compare
SomberNight
changed the title
|
pyinstaller/pyinstaller#6686 is now fixed upstream. |
|
great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bumping the python version bundled inside the Windows binaries, from 3.9.10 to 3.9.11.