Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #2422: fix: regression with XPath attributes in CSS selectors #2423

Merged
merged 8 commits into from Jan 13, 2022
Merged

Backport #2422: fix: regression with XPath attributes in CSS selectors #2423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1066475
test: wrap CSS integration tests in a describe
flavorjones Jan 11, 2022
461811a
style: reformat parser.y
flavorjones Jan 12, 2022
f0ed1e0
fix: regression with XPath attributes in CSS selectors
flavorjones Jan 12, 2022
f7786a3
refactor: extract xpath visitor html5 namespace handling logic
flavorjones Jan 12, 2022
7e876a4
refactor: CSS parser AST uses :ATTRIB_NAME nodes consistently
flavorjones Jan 12, 2022
1de42ce
style: collapse whitespace in css/parser.y
flavorjones Jan 12, 2022
1b90388
doc: improve Searchable#css documentation
flavorjones Jan 12, 2022
fd252a2
doc: update CHANGELOG for #2419
flavorjones Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Expand Up @@ -8,7 +8,8 @@ Nokogiri follows [Semantic Versioning](https://semver.org/), please see the [REA

### Fixed

* Fix `Nokogiri::XSLT.quote_params` regression in v1.13.0 which raised an exception when non-string stylesheet parameters were passed. Non-string parameters (e.g., integers and symbols) are now explicitly supported and both keys and values will be stringified with `#to_s`. [[#2418](https://github.com/sparklemotion/nokogiri/issues/2418)]
* Fix `Nokogiri::XSLT.quote_params` regression in v1.13.0 that raised an exception when non-string stylesheet parameters were passed. Non-string parameters (e.g., integers and symbols) are now explicitly supported and both keys and values will be stringified with `#to_s`. [[#2418](https://github.com/sparklemotion/nokogiri/issues/2418)]
* Fix CSS selector query regression in v1.13.0 that raised an `Nokogiri::XML::XPath::SyntaxError` when parsing XPath attributes mixed into the CSS query. Although this mash-up of XPath and CSS syntax previously worked unintentionally, it is now an officially supported feature and is documented as such. [[#2419](https://github.com/sparklemotion/nokogiri/issues/2419)]


## 1.13.0 / 2022-01-06
Expand Down
691 changes: 351 additions & 340 deletions lib/nokogiri/css/parser.rb
View file
Open in desktop

Large diffs are not rendered by default.