Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #2422: fix: regression with XPath attributes in CSS selectors #2423

Merged
merged 8 commits into from Jan 13, 2022
Merged

Backport #2422: fix: regression with XPath attributes in CSS selectors #2423

merged 8 commits into from Jan 13, 2022

Commits on Jan 12, 2022

  1. test: wrap CSS integration tests in a describe 

    so it's easier to do focused test runs
    @flavorjones
    flavorjones committed Jan 12, 2022
    Copy the full SHA
    1066475 View commit details
    Browse the repository at this point in the history

  2. style: reformat parser.y

    @flavorjones
    flavorjones committed Jan 12, 2022
    Copy the full SHA
    461811a View commit details
    Browse the repository at this point in the history

  3. fix: regression with XPath attributes in CSS selectors 

    This commit removes "@" from the IDENT token so that we can create a
new grammar rule in the parser for XPath attributes.

Fixes #2419
    @flavorjones
    flavorjones committed Jan 12, 2022
    Copy the full SHA
    f0ed1e0 View commit details
    Browse the repository at this point in the history

  4. refactor: extract xpath visitor html5 namespace handling logic

    @flavorjones
    flavorjones committed Jan 12, 2022
    Copy the full SHA
    f7786a3 View commit details
    Browse the repository at this point in the history

  5. refactor: CSS parser AST uses :ATTRIB_NAME nodes consistently 

    All attribute references end up as an :ATTRIB_NAME node without the
"@" present, which simplifies the XPath visitor code.
    @flavorjones
    flavorjones committed Jan 12, 2022
    Copy the full SHA
    7e876a4 View commit details
    Browse the repository at this point in the history

  6. style: collapse whitespace in css/parser.y

    @flavorjones
    flavorjones committed Jan 12, 2022
    Copy the full SHA
    1de42ce View commit details
    Browse the repository at this point in the history

  7. doc: improve Searchable#css documentation 

    And officially document the XPath attribute extensions to CSS selector
syntax that we support.

See #2419 for context
    @flavorjones
    flavorjones committed Jan 12, 2022
    Copy the full SHA
    1b90388 View commit details
    Browse the repository at this point in the history

  8. doc: update CHANGELOG for #2419

    @flavorjones
    flavorjones committed Jan 12, 2022
    Copy the full SHA
    fd252a2 View commit details
    Browse the repository at this point in the history