feat: DocumentFragment constructors all take parse options param #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
1844-fresh-look-at-doc-frag-options-arguments
branch
from
71bd4b2
to
ad16583
Compare
flavorjones
deleted the
1844-fresh-look-at-doc-frag-options-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Similar to Document constructors, we can now pass in parse options as
a parameter or via a config block.
Fixes #1692
Fixes #1844
Co-authored-by: @JackMc
Have you included adequate test coverage?
Yes! Both XML and HTML4 document fragments now have complete test coverage of parse options.
Does this change affect the behavior of either the C or the Java implementations?
Both implementations have been updated.