Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nokogiri::XML::ParseOptions::HUGE doesn't seem to do anything on fragment parsing #1443

Closed
flavorjones opened this issue Mar 6, 2016 · 1 comment
Closed

Nokogiri::XML::ParseOptions::HUGE doesn't seem to do anything on fragment parsing #1443

flavorjones opened this issue Mar 6, 2016 · 1 comment

Comments

@flavorjones
Copy link
Member

See related original PR #431 and related bug report #1442

See code submitted with #1442 for an example of fragment parsing that doesn't obey the HUGE option when parsing deeply-nested trees.

I suspect we're not passing parser options on to the libxml2 parsing context properly. Definitely need to investigate.
@flavorjones flavorjones mentioned this issue Mar 6, 2016
Closed
@flavorjones
Copy link
Member Author

This has been fixed by #2399 (related to #1692).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flavorjones