Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repro test case for #1952 #2024

Closed
wants to merge 1 commit into from
Closed

Conversation

ahorek
Copy link

@ahorek ahorek commented Apr 20, 2020


What problem is this PR intended to solve?
just a test case for #1952

Have you included adequate test coverage?
yes

Does this change affect the C or the Java implementations?
C implementation

@codeclimate
Copy link

codeclimate bot commented Apr 20, 2020

Code Climate has analyzed commit e3265cc and detected 0 issues on this pull request.

View more on Code Climate.

@AppVeyorBot
Copy link

Build nokogiri 1.0.591 failed (commit 7ecf2fa1e8 by @)

@flavorjones
Copy link
Member

@ahorek Thanks for taking the time to do this, I'll dig in.

@flavorjones flavorjones changed the title test segfault repro test case for #1952 Apr 23, 2020
@flavorjones flavorjones added the topic/memory Segfaults, memory leaks, valgrind testing, etc. label Apr 23, 2020
Base automatically changed from master to main January 17, 2021 21:53
@flavorjones
Copy link
Member

PR #2186 uses a slightly clearer test provided in #1952.

@flavorjones flavorjones closed this Feb 5, 2021
@ahorek
Copy link
Author

ahorek commented Feb 5, 2021

@flavorjones great! thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/memory Segfaults, memory leaks, valgrind testing, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants