Native gems: CI should test Linux native 32-bit gem #2120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
changed the title
flavorjones
force-pushed
the
flavorjones-test-native-32bit-gem
branch
from
035d835
to
a31c2c1
Compare
|
This is a WIP because I'm seeing segfaulting on bionic32 that I can't explain, and can't reproduce outside of the CI environment. |
flavorjones
added
packaging/native-gem
release-blocker
flavorjones
added a commit
that referenced
this pull request
Dec 6, 2020
Tripped over this while working on #2120 in a 32-bit CI environment.
|
merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Add test coverage for 32-bit Linux native gems.
We already have coverage for 32-bit Windows native gems within Appveyor:
nokogiri/appveyor.yml
Lines 46 to 49 in fbd65cd
This is follow-on work related to #1984
Have you included adequate test coverage?
The purpose of this PR is to add test coverage.
Does this change affect the C or the Java implementations?
No functional changes.