Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change XmlNodeSet#to_a return type to RubyArray #1969

Closed
wants to merge 2 commits into from
Closed

Change XmlNodeSet#to_a return type to RubyArray #1969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98fee3f
Change return type to RubyArray
headius Jan 14, 2020
17f910c
update to use rake-compiler ~1.1.0
flavorjones Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ gem "hoe-git", "~>1.6", :group => [:development, :test]
gem "minitest", "~>5.8", :group => [:development, :test]
gem "racc", "~>1.4.14", :group => [:development, :test]
gem "rake", "~>12.0", :group => [:development, :test]
gem "rake-compiler", "~>1.0.3", :group => [:development, :test]
gem "rake-compiler", "~>1.1.0", :group => [:development, :test]
gem "rake-compiler-dock", "~>0.7.0", :group => [:development, :test]
gem "rexical", "~>1.0.5", :group => [:development, :test]
gem "rubocop", "~>0.73", :group => [:development, :test]
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
View file
Open in desktop
Expand Up @@ -148,7 +148,7 @@ HOE = Hoe.spec 'nokogiri' do
["minitest", "~> 5.8"],
["racc", "~> 1.4.14"],
["rake", "~> 12.0"],
["rake-compiler", "~> 1.0.3"],
["rake-compiler", "~> 1.1.0"],
["rake-compiler-dock", "~> 0.7.0"],
["rexical", "~> 1.0.5"],
["rubocop", "~> 0.73"],
Expand Down
3 changes: 2 additions & 1 deletion ext/java/nokogiri/XmlNodeSet.java
View file
Open in desktop
Expand Up @@ -39,6 +39,7 @@
import java.util.Arrays;

import org.jruby.Ruby;
import org.jruby.RubyArray;
import org.jruby.RubyClass;
import org.jruby.RubyFixnum;
import org.jruby.RubyObject;
Expand Down Expand Up @@ -391,7 +392,7 @@ public IRubyObject subseq(ThreadContext context, int start, int length) {
}

@JRubyMethod(name = {"to_a", "to_ary"})
public IRubyObject to_a(ThreadContext context) {
public RubyArray to_a(ThreadContext context) {
return context.runtime.newArrayNoCopy(nodes);
}

Expand Down