Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change XmlNodeSet#to_a return type to RubyArray #1969

Closed
wants to merge 2 commits into from

Commits on Jan 14, 2020

  1. Change return type to RubyArray

    The existing signature conflicts with one added to JRuby 9.2.9.
    Specifically, the new signature in JRuby returns RubyArray, which
    causes a compilation error on this line in Nokogiri because it
    attempts to use a more general return type.
    
    We would prefer to keep the specific return type in JRuby.
    
    * If we patch JRuby, then 9.2.9 will never be able to compile any
      version of Nokogiri.
    * If we patch Nokogiri, all versions of JRuby can compile current
      and future Nokogiri. Versions prior to 9.2.9 will be able to
      compile all existing releases of Nokogiri.
    
    I do not believe the change in 9.2.9 breaks anything at runtime,
    since the JVM does not care about this particular return type
    mismatch unless someone actually returns a non-RubyArray object.
    
    Fixes sparklemotion#1968
    headius committed Jan 14, 2020
    Copy the full SHA
    98fee3f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2020

  1. Copy the full SHA
    17f910c View commit details
    Browse the repository at this point in the history