add #value?, plus test #1840
Merged
add #value?, plus test #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This CI failure is unrelated to the change under test, which passes CI. |
flavorjones
force-pushed
the
add_value_predicate_to_node
branch
from
a15e122
to
4909ff3
Compare
|
Just rebased on master to get the PR tests to pass ... |
|
Code Climate has analyzed commit 4909ff3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 50.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 46.3%. View more on Code Climate. |
This was referenced Mar 5, 2021
Closed
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1838