Merge pull request #1840 from MatzFan/add_value_predicate_to_node

add #value?, plus test
sparklemotion · Jan 27, 2020 · 6877a1a · 6877a1a
2 parents d32e332 + 4909ff3
commit 6877a1a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/nokogiri/xml/node.rb b/lib/nokogiri/xml/node.rb
@@ -349,6 +349,12 @@ def values
         attribute_nodes.map(&:value)
       end
 
+      ###
+      # Does this Node's attributes include <value>
+      def value?(value)
+        values.include? value
+      end
+
       ###
       # Get the attribute names for this Node.
       def keys

diff --git a/test/xml/test_node.rb b/test/xml/test_node.rb
@@ -644,6 +644,11 @@ def test_values
         assert_equal %w{ Yes Yes }, @xml.xpath('//address')[1].values
       end
 
+      def test_value?
+        refute @xml.xpath('//address')[1].value?('no_such_value')
+        assert @xml.xpath('//address')[1].value?('Yes')
+      end
+
       def test_keys
         assert_equal %w{ domestic street }, @xml.xpath('//address')[1].keys
       end