Add memray support #7376
Closed
Add memray support #7376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automation
WilliamJamieson
requested review from
kmacdonald-stsci,
zacharyburnett,
stscieisenhamer and
nden
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7376 +/- ##
=======================================
Coverage 76.56% 76.56%
=======================================
Files 456 456
Lines 36877 36877
=======================================
Hits 28234 28234
Misses 8643 8643
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kmacdonald-stsci
approved these changes
Dec 2, 2022
| @@ -78,6 +78,7 @@ test = | |||
| pytest>=6.0.0 | |||
| pytest-cov>=2.9.0 | |||
| pytest-doctestplus>=0.10.0 | |||
| pytest-memray | |||
There was a problem hiding this comment.
Does this require a version number?
7 tasks
zacharyburnett
approved these changes
Dec 5, 2022
|
Unless there are cases/reasons to check memory usage during CI, I would think we do not want it on by default. However, if this feature can be test-specific, developing some canary-in-the-mine tests would be useful. |
stscieisenhamer
approved these changes
Dec 12, 2022
WilliamJamieson
force-pushed
the
ci/memray
branch
from
7cb69a6
to
fd86e1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds usage of the
pytest-memrayplugin to the tests. This is part of the effort to begin tracking memory usage in JWST (and other packages, see SCSB-57.Some questions:
pytest-memrayon by default? Unfortunately, it currently is not supported by Windows and will cause the unit tests to fail during collection if it is used there.pytest-memrayneed documentation somewhere in the JWST docs?pytest-memraydocs? (Maybe this should be done in a series of follow-up PRs)In a future version of
pytest-memraythere should be support for catching memory leaks, see bloomberg/pytest-memray#52. This maybe very useful for catching future memory issues.Note that until bloomberg/pytest-memray#60 is resolved, we should not merge this PR.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR