Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3009: Add cleanups for files left behind while running tests #7375

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Dec 2, 2022

Resolves JP-3009

Closes #7128

This PR adds fixtures to a few tests so that those tests do not leave files generated and saved while running the tests behind. The unit tests for JWST should not leave behind "artifacts" after running as this could interfere with re-running tests and/or lead to those files accidentally being picked up by git.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 79.68% // Head: 79.68% // No change to project coverage 👍

Coverage data is based on head (8ca6c9a) compared to base (e85589c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7375   +/-   ##
=======================================
  Coverage   79.68%   79.68%           
=======================================
  Files         412      412           
  Lines       37576    37576           
=======================================
  Hits        29944    29944           
  Misses       7632     7632           
Flag Coverage Δ *Carryforward flag
nightly 79.67% <ø> (ø) Carriedforward from e85589c
unit 52.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse added this to the Build 9.1 milestone Dec 2, 2022
@hbushouse
Copy link
Collaborator

hbushouse commented Dec 2, 2022

Is this essentially a fix for JP-3009, or does this only cover a subset of tests with this problem?

@WilliamJamieson
Copy link
Collaborator Author

WilliamJamieson commented Dec 2, 2022

Is this essentially a fix for JP-3009, or does this only cover a subset of tests with this problem?

Didn't know at all about JP-3009, I just noticed this while locally testing #7376 and it bothered me. I believe this does in fact resolve JP-3009! (Feel free to assign it to me if you want)

@WilliamJamieson WilliamJamieson changed the title Add cleanups for files left behind while running tests JP-3009: Add cleanups for files left behind while running tests Dec 2, 2022
@hbushouse hbushouse merged commit de5bdf8 into spacetelescope:master Dec 2, 2022
@WilliamJamieson WilliamJamieson deleted the testing/cleanup_files branch December 2, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests polluting the repository working directory
3 participants