Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Pin setuptools to work around ImportError #1861

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 21, 2022

Description

This pull request is to temporarily workaround:

Also see:

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added documentation Explanation of code and concepts Upstream fix required 🔥 Critical trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤backport-v3.1.x on-merge: backport to v3.1.x labels Nov 21, 2022
@pllim pllim added this to the 3.1.1 milestone Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 88.37% // Head: 88.37% // No change to project coverage 👍

Coverage data is based on head (69fd7d0) compared to base (8b4a673).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1861   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files          95       95           
  Lines       10455    10455           
=======================================
  Hits         9240     9240           
  Misses       1215     1215           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim

This comment was marked as resolved.

@pllim pllim marked this pull request as ready for review November 21, 2022 15:39
@pllim
Copy link
Contributor Author

pllim commented Nov 21, 2022

This is ugly but will tie us over for a bit.

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed after fetching this PR and a local install/upgrade! Thanks!

Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I needed this in #1834.

@pllim pllim merged commit 0b9d469 into spacetelescope:main Nov 21, 2022
@pllim pllim deleted the workaround-astropy-14025 branch November 21, 2022 16:34
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Nov 21, 2022
@pllim
Copy link
Contributor Author

pllim commented Nov 21, 2022

Thanks for the approvals!

pllim added a commit that referenced this pull request Nov 21, 2022
…1-on-v3.1.x

Backport PR #1861 on branch v3.1.x (DOC: Pin setuptools to work around ImportError)
@ojustino ojustino mentioned this pull request Nov 28, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts 🔥 Critical no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two Upstream fix required 💤backport-v3.1.x on-merge: backport to v3.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants