Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Unpin setuptools when RTD can build without astropy.convolution error #1863

Closed
pllim opened this issue Nov 21, 2022 · 4 comments · Fixed by #1874
Closed

MNT: Unpin setuptools when RTD can build without astropy.convolution error #1863

pllim opened this issue Nov 21, 2022 · 4 comments · Fixed by #1874
Labels
documentation Explanation of code and concepts Upstream fix required

Comments

@pllim
Copy link
Contributor

pllim commented Nov 21, 2022

Revert #1861 when we can.

Related issues:
@pllim pllim added documentation Explanation of code and concepts Upstream fix required labels Nov 21, 2022
@ojustino
Copy link
Contributor

Have we already done this? Commit 69fd7d from that pull request is an orphan now.

@pllim
Copy link
Contributor Author

pllim commented Nov 28, 2022

No, we have not.

jdaviz/setup.cfg

Lines 59 to 60 in bcc29e7

# setuptools pinned due to https://github.com/astropy/astropy/issues/14025
setuptools<65.6.0

@ojustino
Copy link
Contributor

Looks like I checked main on your fork instead of the real upstream. Sorry for the false alarm

@pllim
Copy link
Contributor Author

pllim commented Nov 28, 2022

Upstream might have been fixed though if you want to open a PR to unpin it. I just haven't gotten to it yet.

@ojustino ojustino mentioned this issue Nov 28, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Explanation of code and concepts Upstream fix required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "DOC: Pin setuptools" ojustino/jdaviz
2 participants
@pllim @ojustino