gitserver: Fix duration reported for ChangedFiles #62603
Merged
+457
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2024
github-actions
bot
added
team/product-platform
team/source
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
724a2e8
to
0fff38b
Compare
eseliger
force-pushed
the
es/05-10-gitserverfixdurationreprotedforchangedfiles
branch
from
4f8fa5f
to
d72bec5
Compare
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
0fff38b
to
ca7ccd8
Compare
eseliger
force-pushed
the
es/05-10-gitserverfixdurationreprotedforchangedfiles
branch
from
d72bec5
to
58c7993
Compare
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
ca7ccd8
to
30fffe6
Compare
eseliger
force-pushed
the
es/05-10-gitserverfixdurationreprotedforchangedfiles
branch
from
58c7993
to
d6d0969
Compare
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
30fffe6
to
ebd8014
Compare
eseliger
force-pushed
the
es/05-10-gitserverfixdurationreprotedforchangedfiles
branch
from
d6d0969
to
245f9d6
Compare
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
ebd8014
to
c975ea1
Compare
eseliger
force-pushed
the
es/05-10-gitserverfixdurationreprotedforchangedfiles
branch
from
245f9d6
to
8d42c6f
Compare
eseliger
changed the title
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
c975ea1
to
6c0847c
Compare
eseliger
force-pushed
the
es/05-10-gitserverfixdurationreprotedforchangedfiles
branch
from
8d42c6f
to
683aa34
Compare
There is potentially a lot of FDs in a repo, so we return an iterator instead to encourage callers to consume it one by one and not load all of it into memory. Test plan: Existing tests still pass.
We always ended the observation when the iterator is created before, this will make sure to track the time until the call to Close(). Test plan: Code review, existing CI.
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
6c0847c
to
76f8aca
Compare
eseliger
force-pushed
the
es/05-10-gitserverfixdurationreprotedforchangedfiles
branch
from
683aa34
to
dfd8c89
Compare
pjlast
approved these changes
May 13, 2024
Base automatically changed from
es/05-10-gitservermakereaddirreturnaniteratoronclientside
to
main
May 13, 2024 12:24
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always ended the observation when the iterator is created before, this will make sure to track the time until the call to Close().
Test plan:
Code review, existing CI.