gitserver: Make ReadDir return an iterator on client side #62602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2024
github-actions
bot
added
team/product-platform
team/source
eseliger
force-pushed
the
es/05-08-gitservermoveimplementationofhascommitaftertocaller
branch
from
ba2b1e9
to
78320cc
Compare
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
2 times, most recently
from
d630626
to
724a2e8
Compare
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
2 times, most recently
from
0fff38b
to
ca7ccd8
Compare
eseliger
force-pushed
the
es/05-08-gitservermoveimplementationofhascommitaftertocaller
branch
from
78320cc
to
4585dee
Compare
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
ca7ccd8
to
30fffe6
Compare
eseliger
force-pushed
the
es/05-08-gitservermoveimplementationofhascommitaftertocaller
branch
from
4585dee
to
65dc9a0
Compare
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
2 times, most recently
from
ebd8014
to
c975ea1
Compare
eseliger
force-pushed
the
es/05-08-gitservermoveimplementationofhascommitaftertocaller
branch
from
65dc9a0
to
7d13e41
Compare
Base automatically changed from
es/05-08-gitservermoveimplementationofhascommitaftertocaller
to
main
May 10, 2024 23:36
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
c975ea1
to
6c0847c
Compare
There is potentially a lot of FDs in a repo, so we return an iterator instead to encourage callers to consume it one by one and not load all of it into memory. Test plan: Existing tests still pass.
eseliger
force-pushed
the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
from
6c0847c
to
76f8aca
Compare
pjlast
approved these changes
May 13, 2024
eseliger
deleted the
es/05-10-gitservermakereaddirreturnaniteratoronclientside
branch
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is potentially a lot of FDs in a repo, so we return an iterator instead to encourage callers to consume it one by one and not load all of it into memory.
Test plan:
Existing tests still pass.