Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/output: forcibly disable dark background detection in Buildkite #38694

Closed
wants to merge 1 commit into from

Conversation

bobheadxi
Copy link
Member

A customer reported:

So it looks like github.com/sourcegraph/sourcegraph/lib/output.NewOutput hangs when run by our Buildkite agent see line of code here
I patched src-cli and use fmt.Print to isolate the problem to there. (I am unsure I can get a debugger here)

We ran into the same issue with sg usage in Buildkite, which we patched in #36193. We can't easily apply a similar patch for src because there are many points where output is initialized (query) but at the end of the day I think it makes sense for detectCapabilities to house this logic, since all users of this package will run into this issue and it fits in with the need to "detect capabilities"

Test plan

n/a

@bobheadxi bobheadxi requested review from mrnugget, eseliger and a team July 12, 2022 22:04
@cla-bot cla-bot bot added the cla-signed label Jul 12, 2022
@jlisee
Copy link

jlisee commented Jul 13, 2022

I did a quick deep dive (using sourcegraph itself to walk the cross repo call chain), and found the smoking gun and root fix - muesli/termenv#52 - Don't run OSC queries on CI

Updating muesli/termenv to >= 0.11 in sourcegraph/src-cli also fixes the issue without needing any code changes or Buildkite knowledge.

For reference the call chain - The call chain:

@bobheadxi
Copy link
Member Author

Thank you @jlisee for digging deeper :) I'll make the appropriate updates!

@bobheadxi bobheadxi closed this Jul 13, 2022
@bobheadxi bobheadxi deleted the lib-output-buildkite-workaround branch July 13, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants