deps: upgrade to github.com/muesli/termenv@v0.12.0 #38765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in OWNERS files for diff 1ce7411...11f7c49.
|
|
We getting output: |
vovakulikov
pushed a commit
that referenced
this pull request
Jul 20, 2022
This should resolve some issues we are seeing with terminal detection that causes users of lib/output to hang when running in Buildkite environments, which also means we can remove the ForceDarkBackground workaround in sg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve some issues we are seeing with terminal detection that causes users of
lib/outputto hang when running in Buildkite environments - thanks to @jlisee for finding this: #38694 (comment)I will follow up with a patch to
src-cliTest plan
I've removed the
ForceDarkBackgroundworkaround in Buildkite - if thesg lintstep renders correctly, then the patch has worked.