Render blob panel even if the highlighting request failed #11034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused #10999 where no git history would show up, because the request for the highlighted content fails, as the file is binary.
eseliger
added
bug
| @@ -240,6 +240,14 @@ export class BlobPage extends React.PureComponent<Props, State> { | |||
| } | |||
| repoHeaderContributionsLifecycleProps={this.props.repoHeaderContributionsLifecycleProps} | |||
| /> | |||
| <BlobPanel | |||
There was a problem hiding this comment.
Does it make no difference that this is now in the top of the DOM (before the file content) and not at the end?
Wish this component had screenshot tests...
There was a problem hiding this comment.
It actually renders nothing, it's just a view provider wrapper. If that sounds safe enough, wanna approve? :)
felixfbecker
approved these changes
May 27, 2020
|
Changelog entry pls :) |
eseliger
added a commit
that referenced
this pull request
May 28, 2020
eseliger
added a commit
that referenced
this pull request
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused #10999 where no git history would show up, because the
request for the highlighted content fails, as the file is binary.
The Blob panel should be rendered independently of the blob content. That way
Closes #10999