No Git file history for binary files

[dadlerj]

Requested by https://app.hubspot.com/contacts/2762526/company/578600789

Sourcegraph doesn't render binary files (#8387), but apparently it also isn't able to show Git history:

Related:

• Binary files in patch always show "no changes" #10998
• Image files should be rendered #8387

Not urgent, but if a quick fix, would be a nice customer win!

[tsenart]

@keegancsmith: Before I dive in, any clue where the root cause may be?

[keegancsmith]

No idea. Maybe our parsing of git log fails with binary files? Not sure why it would care about contents of files for log (except for detecting renames, but even then I don't see why log would change).

That would be my best guess. In fact @eseliger is adding support for binary files in our diff parser 1. This may be a hint towards the issue.

[tsenart]

@eseliger: Could you perhaps take a brief look at this as part of #10998? cc @mrnugget

[eseliger]

The cause is that the request fails with an error, because highlighting doesn't work. I think the proper fix is making highlight nullable in graphql and in the frontend don't fail if it's only that error. Want me to do a fix here or will someone else take it?

Found a much simpler fix, sorry for confusion. I'll push it soon

[eseliger]

Fix is here: #11034