Skip to content

Commit

Permalink
Render blob panel even if the highlighting request failed
Browse files Browse the repository at this point in the history
This caused #10999 where no git history would show up, because the
request for the highlighted content fails, as the file is binary.
  • Loading branch information
eseliger committed May 27, 2020
1 parent eea209a commit 8ccb403
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions web/src/repo/blob/BlobPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,14 @@ export class BlobPage extends React.PureComponent<Props, State> {
}
repoHeaderContributionsLifecycleProps={this.props.repoHeaderContributionsLifecycleProps}
/>
<BlobPanel
{...this.props}
position={
lprToRange(parseHash(this.props.location.hash))
? lprToRange(parseHash(this.props.location.hash))!.start
: undefined
}
/>
</>
)

Expand Down Expand Up @@ -317,14 +325,6 @@ export class BlobPage extends React.PureComponent<Props, State> {
renderMode={renderMode}
/>
)}
<BlobPanel
{...this.props}
position={
lprToRange(parseHash(this.props.location.hash))
? lprToRange(parseHash(this.props.location.hash))!.start
: undefined
}
/>
</>
)
}
Expand Down

0 comments on commit 8ccb403

Please sign in to comment.