Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush errors after namer and resolver #7796

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Flush errors after namer and resolver #7796

wants to merge 19 commits into from
+430 −73

Commits on Jun 13, 2024

  1. Add method to deep clone ErrorQueueMessage 

    Add clone() method to the header file
    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ef16ac0 View commit details
    Browse the repository at this point in the history

  2. Remove filesFlushedCount

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    994304f View commit details
    Browse the repository at this point in the history

  3. Add flushButRetainErrorsForFile method to the ErrorQueue 

    The method flushes errors, and also makes a copy of each error to store
it in the error cache in the GlobalState
    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    fd47f0c View commit details
    Browse the repository at this point in the history

  4. Update invariants regarding metric timers

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0fc2ae5 View commit details
    Browse the repository at this point in the history

  5. Duplicate errors 7010 and 7032 in errors::Resolver

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    829c337 View commit details
    Browse the repository at this point in the history

  6. Use new errors and update tests

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3f6e8a3 View commit details
    Browse the repository at this point in the history

  7. Add LSP error cache and method to invalidate it to GlobalState

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0bc79bc View commit details
    Browse the repository at this point in the history

  8. Update signatures for flushing functions in ErrorQueue

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    02ae6f6 View commit details
    Browse the repository at this point in the history

  9. ErrorQueue: Add new flushing functions and use error cache in old ones

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    dd99387 View commit details
    Browse the repository at this point in the history

  10. Add additonal error flushes after namer and resolver

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f580365 View commit details
    Browse the repository at this point in the history

  11. Flush error cache after typecheck. Also update pipeline::typecheck si… 

    …gnature
    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3bdd974 View commit details
    Browse the repository at this point in the history

  12. Invalidate cache before calling pipeline::typecheck and update it after

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    67f9d1c View commit details
    Browse the repository at this point in the history

  13. Clear cache after LSPQuery typecheck

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3c3c101 View commit details
    Browse the repository at this point in the history

  14. Update incremental-lsp-changes.rec

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3d9c1dd View commit details
    Browse the repository at this point in the history

  15. Update multithreaded_protocol_test_corpus.cc

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    98df5f9 View commit details
    Browse the repository at this point in the history

  16. Handle LSP error cache in lsp_test_runner.cc

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    30216a1 View commit details
    Browse the repository at this point in the history

  17. Handle error cache in pipeline_test_runner.cc

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a4ba703 View commit details
    Browse the repository at this point in the history

  18. tools/scripts/format_cxx.sh

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0e18259 View commit details
    Browse the repository at this point in the history

  19. Add docs for errors 5076 and 5077

    @ilyailya
    ilyailya committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a9744c2 View commit details
    Browse the repository at this point in the history