New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flush errors after namer and resolver #7796
Draft
ilyailya
wants to merge
14
commits into
master
Choose a base branch
from
iz/error-flush
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method flushes errors, and also makes a copy of each error to store it in the error cache in the GlobalState
The method fetches existing errors from the error cache and clears the cache afterwards
The method fetches additional errors from the cache before flushing, but doesn't add new errors into the cache
That might change in the future. For example, it would be useful to leave errors after typecheck to reuse them for codeAction requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR flushes errors after running the namer and the resolver.
The change also adds cache for the errors, preventing Sorbet from losing errors due to additional flushes
Motivation
This would make Sorbet feel more responsive, as errors would be displayed more quickly in LSP mode.
I tested the PR on Stripe's codebase by inserting a specific piece of code and tracking the timing of error reports through LSP logs
Test plan
See included automated tests.