Fix deprecation for symfony/config 4.2+ #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you tell us what deprecation there is, and how your changes fixes it? |
OskarStark
previously approved these changes
Dec 16, 2018
|
Using TreeBuilder without root node as constructor argument is deprecated since 4.2 @greg0ire |
greg0ire
reviewed
Dec 16, 2018
greg0ire
approved these changes
Dec 16, 2018
|
If that's ok I can make other PR to other bundles of Sonata |
|
That would be awesome! |
This was referenced Dec 16, 2018
|
I have to leave now, I'll continue later! |
This was referenced Dec 16, 2018
This was referenced Dec 16, 2018
core23
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This is to fix deprecation for symfony/config 4.2+
I am targeting this branch, because is the one with this warning.
Changelog
### Fixed Fix deprecation for symfony/config 4.2+I added the ConfigurationTest class, but I wasn't sure what to test 馃槵so I used https://github.com/sonata-project/SonataAdminBundle/blob/3.x/tests/DependencyInjection/ConfigurationTest.php as an example.
The fix is like doctrine/DoctrineBundle#853