Fix deprecation for symfony/config 4.2+ #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Dec 16, 2018
OskarStark
reviewed
Dec 16, 2018
| @@ -29,8 +29,14 @@ class Configuration implements ConfigurationInterface | |||
| */ | |||
| public function getConfigTreeBuilder() | |||
| { | |||
| $treeBuilder = new TreeBuilder(); | |||
| $rootNode = $treeBuilder->root('sonata_admin', 'array'); | |||
| $treeBuilder = new TreeBuilder('sonata_admin'); | |||
There was a problem hiding this comment.
What does the „array“ mean? No need to keep it somehow?
There was a problem hiding this comment.
It has been the default value of the TreeBuilder::root method and also of the new the constructor.
OskarStark
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This is to fix deprecation for symfony/config 4.2+ as in sonata-project/SonataDoctrineORMAdminBundle#871
I am targeting this branch, because is the one with this warning.
Changelog