Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Solidus Frontend #2

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Inline Solidus Frontend #2

merged 5 commits into from
Jun 29, 2022

Commits on Jun 29, 2022

  1. Remove script/rails 

    Doesn't seem used. Getting the following error when I run it:

```
solidus_frontend-3.1.5/lib/spree/frontend_configuration.rb:4:in `<module:Spree>': uninitialized constant Spree::Preferences (NameError)
```
    @gsmendoza
    gsmendoza committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    143464d View commit details
    Browse the repository at this point in the history

  2. Separate SolidusFrontend version from Solidus version

    @gsmendoza
    gsmendoza committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f169a72 View commit details
    Browse the repository at this point in the history

  3. Inline Solidus dependencies in Gemfile 

    Decouple Gemfile from solidus.gemspec.

We're using the '**/*.gemspec' glob format for the gem statements so
that we can work around this issue:

"Bundler cannot add multiple gems from the same git source"
rubygems/bundler#7346
    @gsmendoza
    gsmendoza committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    d848035 View commit details
    Browse the repository at this point in the history

  4. [BREAK CI] Remove Solidus dependencies

    @gsmendoza
    gsmendoza committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    6eb876b View commit details
    Browse the repository at this point in the history

  5. Move frontend to root directory

    @gsmendoza
    gsmendoza committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    26be4f7 View commit details
    Browse the repository at this point in the history