Inline Solidus Frontend #2
Conversation
gsmendoza
force-pushed
the
gsmendoza/eng-310-fork-solidus_frontend-into-a-separate--inline-frontend
branch
from
c1007e6
to
fce3ee9
Compare
|
👍 |
|
|
||
| # Solidus | ||
| Frontend contains controllers and views implementing a storefront and cart for Solidus. |
There was a problem hiding this comment.
I would add a notice to let new users know that this is not the recommended frontend anymore.
| // | ||
| //= require spree/backend/turbolinks-integration.js | ||
| ``` | ||
| ## Testing |
There was a problem hiding this comment.
We're not adding tests to the host application if I'm not wrong. So I think this section should instead be called "Contributing".
There was a problem hiding this comment.
Thanks, @gsmendoza, I left some minor comments. Also:
- Could we reconfigure CI to be sure everything is well tied?
- I think you can remove
.dockerdev/anddocker-compose.ymlfor now.
I saw your comment on #1, so I'm ok with doing that there. |
Ok, I also saw your checkbox about it in #1. So, if it's working, we can leave it. Did you try to run tests? |
|
I'll move those comments to #1, as it's where they belong. |
Yep, I was able to get |
|
Closing PR since #1 is more up-to-date. |
gsmendoza
force-pushed
the
gsmendoza/eng-310-fork-solidus_frontend-into-a-separate--inline-frontend
branch
from
fce3ee9
to
bb34985
Compare
|
Reopening the PR because #2 is too difficult to comment on with its changes. |
gsmendoza
force-pushed
the
gsmendoza/eng-310-fork-solidus_frontend-into-a-separate--inline-frontend
branch
4 times, most recently
from
a448708
to
db88c10
Compare
Doesn't seem used. Getting the following error when I run it: ``` solidus_frontend-3.1.5/lib/spree/frontend_configuration.rb:4:in `<module:Spree>': uninitialized constant Spree::Preferences (NameError) ```
gsmendoza
force-pushed
the
gsmendoza/eng-310-fork-solidus_frontend-into-a-separate--inline-frontend
branch
from
db88c10
to
de6b9e1
Compare
| gem 'solidus_api', github: 'solidusio/solidus', glob: '**/*.gemspec' | ||
| gem 'solidus_backend', github: 'solidusio/solidus', glob: '**/*.gemspec' | ||
| gem 'solidus_core', github: 'solidusio/solidus', glob: '**/*.gemspec' | ||
| gem 'solidus_frontend', github: 'solidusio/solidus', glob: '**/*.gemspec' | ||
| gem 'solidus_sample', github: 'solidusio/solidus', glob: '**/*.gemspec' |
There was a problem hiding this comment.
The glob format is a workaround for this issue: "Bundler cannot add multiple gems from the same git source" (rubygems/bundler#7346).
Decouple Gemfile from solidus.gemspec. We're using the '**/*.gemspec' glob format for the gem statements so that we can work around this issue: "Bundler cannot add multiple gems from the same git source" rubygems/bundler#7346
gsmendoza
force-pushed
the
gsmendoza/eng-310-fork-solidus_frontend-into-a-separate--inline-frontend
branch
from
de6b9e1
to
26be4f7
Compare
kennyadsl
deleted the
gsmendoza/eng-310-fork-solidus_frontend-into-a-separate--inline-frontend
branch
This is actually part of #1, but I've separated these commits from that PR to make the diff of that PR easier to view. For this PR, I'd recommend going through the individual commits instead of viewing the PR diff.