Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix option_values_hash form field name name #65

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 17, 2024

In Rack 3 the wrongly formatted option_values_hash stopped working. It was an accident that this ever worked in Rack 1 and 2

See rack/rack#2128

In Rack 3 the wrongly formatted `option_values_hash` stopped working.
It was an accident that this ever worked in Rack 1 and 2

See rack/rack#2128
@tvdeyen
Copy link
Member Author

tvdeyen commented Apr 17, 2024

The specs are failing because of the changes we need to do in #64 for latest Zeitwerk

@tvdeyen tvdeyen merged commit 92060aa into solidusio-contrib:main Apr 17, 2024
1 of 5 checks passed
@tvdeyen tvdeyen deleted the fix-for-rack-3 branch April 17, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant