Replace Deface Override with Deface DSL #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤣 The 
|
tvdeyen
reviewed
Apr 15, 2024
...s/spree/admin/product_properties/index/prototypes_product_properties_toolbar.html.erb.deface
Outdated
Show resolved
Hide resolved
|
@sascha-karnatz spec failure seems to be legit |
sascha-karnatz
force-pushed
the
replace-deface-override-with-dsl
branch
2 times, most recently
from
2367d1a
to
7c7bb08
Compare
|
Specs started to fail with Rack 3.0 because of how nested params are handled in https://github.com/solidusio-contrib/solidus_prototypes/blob/main/app/views/spree/admin/prototypes/show.html.erb#L14 See rack/rack#2128 Possible solutions:
|
This was referenced Apr 17, 2024
Merged
The override objects don't work great in a combination of Rails 7.1 and Zeitwerk. Also the html.erb.deface can contain the partial itself and it is possible to remove the additional partials.
tvdeyen
force-pushed
the
replace-deface-override-with-dsl
branch
from
7c7bb08
to
3ed7ba5
Compare
|
Rebased with latest |
tvdeyen
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The override objects don't work great in a combination of Rails 7.1 and Zeitwerk. Also the html.erb.deface can contain the partial itself and it is possible to remove the additional partials.
One of the overrides had a typo (insert_bottom: "ul.tollbar") and it is most likely that it didn't worked for the last 8 years. It was also not possible to find the selectors for '[data-hook="new_product_tax_category"]', and '[data-hook="new_product_price"]'. Maybe it is possible to remove these defaces if they not in use anymore.