Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: improve Kotlin code #1558

Merged
merged 65 commits into from Sep 16, 2022
Merged

style: improve Kotlin code #1558

merged 65 commits into from Sep 16, 2022

Commits on Aug 11, 2022

  1. chore: add method for resolving appropriate fragment manager

    @kkafar
    kkafar committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3d497f8 View commit details
    Browse the repository at this point in the history

  2. fix: resolve appropriate fragment manager

    @kkafar
    kkafar committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    843877a View commit details
    Browse the repository at this point in the history

  3. refact: change method name

    @kkafar
    kkafar committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    caa9bc8 View commit details
    Browse the repository at this point in the history

  4. chore: make return type non nullable

    @kkafar
    kkafar committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    14447e8 View commit details
    Browse the repository at this point in the history

  5. chore: clarify comments & simplify logic

    @kkafar
    kkafar committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b8067da View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. chore: refactor code & add checks

    @kkafar
    kkafar committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    94ff164 View commit details
    Browse the repository at this point in the history

  2. fix: typo

    @kkafar
    kkafar committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    085358b View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2022

  1. refact: another typo

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    20ca3fe View commit details
    Browse the repository at this point in the history

  2. chore: take advantage of FragmentManager#findFragment method 

    Also add some comments that describe the changes
    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    67c1220 View commit details
    Browse the repository at this point in the history

  3. chore: add link to the issue

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    986b65c View commit details
    Browse the repository at this point in the history

  4. refact: use checkNotNull in place of explicit comparision against null

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    fa9a43f View commit details
    Browse the repository at this point in the history

  5. style: Kotlin

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    8c8429d View commit details
    Browse the repository at this point in the history

  6. refact: ScreenContainer#createTransaction

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    539ad64 View commit details
    Browse the repository at this point in the history

  7. refact: ScreenContainer#{getActivityState,hasScreen}

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    256721b View commit details
    Browse the repository at this point in the history

  8. refact: ScreenContainer#getScreenAt

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    07c6674 View commit details
    Browse the repository at this point in the history

  9. refact: ScreenContainer#removeMyFragments

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    a4e52b8 View commit details
    Browse the repository at this point in the history

  10. refact: ScreenContainer#topScreen

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    37bdbd8 View commit details
    Browse the repository at this point in the history

  11. refact: ScreenContainer#onMeasure

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    ed743e8 View commit details
    Browse the repository at this point in the history

  12. refact: ScreenContainer#onUpdate

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    8861605 View commit details
    Browse the repository at this point in the history

  13. refact: ScreenStackViewManager#getName

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    42abad1 View commit details
    Browse the repository at this point in the history

  14. refact: ScreenStackViewManager#createViewInstance

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    a03b6ce View commit details
    Browse the repository at this point in the history

  15. refact: ScreenStackViewManager#startTransitionRecursive

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    6329a62 View commit details
    Browse the repository at this point in the history

  16. refact: ScreenStackViewManager#(series of getters)

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    b301661 View commit details
    Browse the repository at this point in the history

  17. refact: ScreenStackFragment#setToolbar

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    b8ce077 View commit details
    Browse the repository at this point in the history

  18. refact: ScreenStackFragment#onContainerUpdate

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    fcd88b8 View commit details
    Browse the repository at this point in the history

  19. refact: ScreenStackFragment#onCreateView

    @kkafar
    kkafar committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    71f5de7 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. refact: ScreenStackFragment#updateToolbarMenu

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    8b77b28 View commit details
    Browse the repository at this point in the history

  2. refact: ScreenStackFragment#startAnimation

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    33116c5 View commit details
    Browse the repository at this point in the history

  3. refact: CustomSearchView

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    076bac8 View commit details
    Browse the repository at this point in the history

  4. refact: LifecycleHelper#unregister

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    9219570 View commit details
    Browse the repository at this point in the history

  5. refact: RNSScreenPackage#createNativeModules

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    251f1a8 View commit details
    Browse the repository at this point in the history

  6. refact: Screen#headerConfig

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    51427f3 View commit details
    Browse the repository at this point in the history

  7. refact: ScreenContainerViewManager

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    3c1d887 View commit details
    Browse the repository at this point in the history

  8. refact: ScreenFragment#onCreateView

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    0da9a3d View commit details
    Browse the repository at this point in the history

  9. refact: ScreenFragment#canDispatchEvent

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    b00faad View commit details
    Browse the repository at this point in the history

  10. refact: ScreenFragment#dispatchEventInChildContainers

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    614ab52 View commit details
    Browse the repository at this point in the history

  11. refact: ScreenFragment#dispatchHeaderBackButtonClickedEvent

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    bd95c10 View commit details
    Browse the repository at this point in the history

  12. refact: ScreenFragment#dispatchTransitionProgress

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    15c4fb8 View commit details
    Browse the repository at this point in the history

  13. refact: ScreenFragment#onDestroy

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    52693ec View commit details
    Browse the repository at this point in the history

  14. refact: ScreenStack#rootScreen

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    a719766 View commit details
    Browse the repository at this point in the history

  15. refact: ScreenStack#adapt

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    13824db View commit details
    Browse the repository at this point in the history

  16. refact: ScreenStack#dispatchonfinishTransitioning

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    9dc50f9 View commit details
    Browse the repository at this point in the history

  17. refact: ScreenStack#removeScreenAt

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    25db443 View commit details
    Browse the repository at this point in the history

  18. refact: ScreenStack#hasScreen

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    96c9ae0 View commit details
    Browse the repository at this point in the history

  19. refact: spotless for ScreenContainer

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    de32e7d View commit details
    Browse the repository at this point in the history

  20. chore: add RNSUtil with forEachSatisfying method

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    5298956 View commit details
    Browse the repository at this point in the history

  21. refact: ScreenStack#notifyContainerUpdate

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    527575c View commit details
    Browse the repository at this point in the history

  22. refact: ScreenStack#obtainDrawingOp

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    78a9646 View commit details
    Browse the repository at this point in the history

  23. refact: ScreenStack#companion

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    4a38f22 View commit details
    Browse the repository at this point in the history

  24. refact: ScreenStackHeaderConfig#screen

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    eac18b7 View commit details
    Browse the repository at this point in the history

  25. refact: ScreenStackHeaderConfig#screenStack

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    10bcf89 View commit details
    Browse the repository at this point in the history

  26. refact: ScreenStackHeaderConfig#onUpdate

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    3744c35 View commit details
    Browse the repository at this point in the history

  27. refact: ScreenStackHeaderConfig#getConfigSubview

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    abd434f View commit details
    Browse the repository at this point in the history

  28. refact: ScreenStackHeaderConfig#titleTextView

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    fc2cc56 View commit details
    Browse the repository at this point in the history

  29. refact: ScreenStackHeaderConfigViewManager

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    97e4f5f View commit details
    Browse the repository at this point in the history

  30. refact: ScreenStackHeaderSubview

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    c7cc6ac View commit details
    Browse the repository at this point in the history

  31. refact: ScreenStackHeaderSubview

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    ad82b8a View commit details
    Browse the repository at this point in the history

  32. refact: ScreenStackheaderConfig#getName v2

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    e43d03a View commit details
    Browse the repository at this point in the history

  33. refact: ScreenViewManager

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    55bfaf8 View commit details
    Browse the repository at this point in the history

  34. refact: ScreenWindowTraits

    @kkafar
    kkafar committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    6011a75 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. fix: ScreenStackHeaderSubview#config

    @kkafar
    kkafar committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    088f25b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. fix: restore initial logic in ScreenFragment#onCreateView

    @kkafar
    kkafar committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    c370c24 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into @kkafar/improve-kotlin

    @kkafar
    kkafar committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    7ab0d70 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. style: apply review suggestions

    @kkafar
    kkafar committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    7aad6e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. chore: merge in main 

    Merge branch 'main' into @kkafar/improve-kotlin
    @kkafar
    kkafar committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    c8543d7 View commit details
    Browse the repository at this point in the history